reasonix-desktop: Add version 1.12.0#18019
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates the DeepSeek-Reasonix Scoop package manifest from version 1.5.0 to version 1.10.0. The manifest now includes both Windows amd64 and arm64 release artifacts, each with its own GitHub download URL and SHA256 hash. The executable binary configuration (Reasonix.exe with Reasonix shortcut), GitHub-based version detection regex (desktop-v([\d.]+)), and autoupdate URL templating remain unchanged, with autoupdate now rewriting both amd64 and arm64 download URLs using the discovered version. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bucket/deepseek-reasonix.json (1)
1-31: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winReminder: Ensure CRLF line endings.
Scoop manifests must use CRLF (Windows-style) line endings. Please verify that this file uses CRLF line endings, not LF (Unix-style).
As per coding guidelines: "Line Endings: Scoop manifests must use CRLF line endings. Remind the contributor if you detect LF."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/deepseek-reasonix.json` around lines 1 - 31, The manifest file deepseek-reasonix.json currently must use Windows CRLF line endings; convert the file's line endings from LF to CRLF (ensure the entire JSON including keys like "version", "bin": "Reasonix.exe" and the "autoupdate" block ends with CRLF) and re-save the file so the repository contains CRLF line endings for this scoop manifest.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/deepseek-reasonix.json`:
- Line 4: Update the "homepage" field in the deepseek-reasonix.json manifest
from "http://reasonix.io/" to "https://reasonix.io/"; if you prefer to keep
HTTP, verify that the HTTP URL properly redirects to HTTPS and document that
verification, but the change should be made by editing the homepage property
value to use the HTTPS URL.
---
Outside diff comments:
In `@bucket/deepseek-reasonix.json`:
- Around line 1-31: The manifest file deepseek-reasonix.json currently must use
Windows CRLF line endings; convert the file's line endings from LF to CRLF
(ensure the entire JSON including keys like "version", "bin": "Reasonix.exe" and
the "autoupdate" block ends with CRLF) and re-save the file so the repository
contains CRLF line endings for this scoop manifest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b613e37a-1ec5-4bef-b6a8-cf653c11362e
📒 Files selected for processing (1)
bucket/deepseek-reasonix.json
|
All changes look good. Wait for review from human collaborators. deepseek-reasonix
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with deepseek-reasonix
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. deepseek-reasonix
|
Updated version from 1.5.0 to 1.10.0 with new architecture support.
JackieJK
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. deepseek-reasonix
|
|
Can CLI be added to the bucket? |
这应该被添加到Main而不是Extra |
|
I guess it would make sense to separate manifests for desktop/cli version using more appropriate names. |
JackieJK
changed the title
|
…tcuts, remove bin Remove bin section to avoid possible interference with cli version (ScoopInstaller/Main#8215)
aliesbelik
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. reasonix-desktop
|
3 participants
Closes #17989
<manifest-name[@version]|chore>: <general summary of the pull request>